Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert OpenCV version change #706

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

ashokkumarkannan1
Copy link
Contributor

Fix: #703

Previously CI was blocked with ImportError: ERROR: recursion is detected during loading of "cv2" binary extensions. Check OpenCV installation. issue. As per the suggestion here, downgraded the opencv-python-headless version from 4.6.0.66 to 4.5.5.64 in this PR.

Now this was blocking the MNIST Model with this issue. Hence reverting this change to see whether it still affect the CI.

Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gfengTT @ashokkumarkannan1 can we try to use some newer version of OpenCV that doesn't hit this issue?

This more seems like bug in one of their version, so let's just test out newer one and see will that fix the issue, rather than downgrading it back again :))

Note: Here is an example of a similar failure. I'm not sure if it's the same issues, but let's try to keep our libraries on newer versions, rather than downgrading them.

@ashokkumarkannan1
Copy link
Contributor Author

@gfengTT @ashokkumarkannan1 can we try to use some newer version of OpenCV that doesn't hit this issue?

This more seems like bug in one of their version, so let's just test out newer one and see will that fix the issue, rather than downgrading it back again :))

Note: Here is an example of a similar failure. I'm not sure if it's the same issues, but let's try to keep our libraries on newer versions, rather than downgrading them.

I agree with your point @nvukobratTT . From this Release History page, it seems 4.10.0.84 is the latest stable version. I will update this change here in this PR to verify is there any CI failures here.

@gfengTT Can you please confirm from your side whether 4.10.0.84 version works from your side?

@gfengTT
Copy link
Contributor

gfengTT commented Nov 14, 2024

Great suggestion @nvukobratTT .

@ashokkumarkannan1 Confirming 4.10.0.84 works.

@nvukobratTT
Copy link
Contributor

@ashokkumarkannan1 make sure to update PR name to reflect new changes :))

@ashokkumarkannan1 ashokkumarkannan1 merged commit 5d79f2d into main Nov 15, 2024
6 checks passed
@ashokkumarkannan1 ashokkumarkannan1 deleted the akannan/revert-opencv-version branch November 15, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mnist test failure
4 participants